TTRPG-Dev / ex_ttrpg_dev / c264c00d0ee14980f070f0fa0055efc9ae93ec98-PR-83

95%

main: 87%

Build Type

Pull #83

github

Committed by QMalcolm

Commit Message

refactor(characters): generalize selection-type progressions

Removes spell-specific hardcoding from the library and engine. Any
selection-type character progression can now be defined without code
changes by adding a `type` key to the progression config.

The `active_in` filter key (with `field` and `type` subkeys) replaces
the hardcoded `meta["classes"]` / `{"class", cls}` check in
`spell_options`. Spell progressions now declare this in TOML rather than
relying on engine knowledge of the spell concept schema.

Renamed: spell_progression_choices → selection_progression_choices,
spell_options → concept_options (now public), spell_level_filter →
level_filter, serialize_known_spells → serialize_selected_concepts,
known_spells response key → selected_concepts.

The dispatch in pending_choices/3 switches from matching on the literal
"spell" string to checking Map.has_key?(meta, "type"), so any future
selection-type progression works without touching the library.

Pull Request Pull Request #83: feat(dnd_5e_srd): spell availability — cantrips and spells known

Coverage Stats

27 of 31 new or added lines in 1 file covered. (87.1%)

2 existing lines in 1 file now uncovered.

494 of 520 relevant lines covered (95.0%)

15124.63 hits per line