solidjs / solid / 23510328585

85%

Build Type

push

github

Committed by web-flow

Commit Message

fix: lazily create inTransition external source to prevent use-after-dispose (#2589)

* fix: lazily create inTransition external source to prevent use-after-dispose

The inTransition external source was eagerly created and disposed after
each transition resolved. When a subsequent transition started, the
disposed source was still referenced, causing errors when .track() was
called on it.

This change makes inTransition lazily initialized on first use during a
transition and properly re-created after disposal. Fixes #2275.

* add changeset for external source transition fix

* Fix lazy external source recreation

Preserve the original computation function when lazily creating the transition-scoped external source and make the regression test cleanup deterministic.

Made-with: Cursor

* Format external source follow-up changes

Include the formatting updates applied by the pre-commit hook so the PR branch is clean before pushing.

Made-with: Cursor

---------

Co-authored-by: Ryan Carniato <ryansolid@gmail.com>

Coverage Stats

927 of 1147 branches covered (80.82%)

Branch coverage included in aggregate %.

6 of 15 new or added lines in 1 file covered. (40.0%)

30 existing lines in 2 files now uncovered.

2370 of 2685 relevant lines covered (88.27%)

62.92 hits per line