trixi-framework / Trixi.jl / 23497404996

97%

Build Type

push

github

Committed by web-flow

Commit Message

Refactor DGMulti by consolidating functionality into `local_flux_differencing!` (#2857)

* Refactoring shock capturing for DGMulti

* formatting

* Refactor local_flux_differencing! to eliminate LazyMatrixLinearCombo

Dense conservative path now uses a per-pair loop with a single flux call
using normal direction n_ij = geometric_matrix * ref_entries, replacing
the dimension-by-dimension LazyMatrixLinearCombo + hadamard_sum! approach.
Sparse non-conservative path replaces LazyMatrixLinearCombo((Q,),(0.5,))
with 0.5 * normal_direction. Removes build_lazy_physical_derivative,
LazyMatrixLinearCombo, and the now-unused hadamard_sum! overloads.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* formatting

* Restore hadamard_sum! overload for NonAffine curved meshes

The per-pair normal-averaging overload for AbstractVector{<:AbstractVector}
was accidentally removed. On NonAffine meshes, get_contravariant_vector
returns an SVector of per-node array views; this overload averages the
normals at nodes i and j before calling the volume flux.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fix sbp.jl FD-SBP volume integral after hadamard_sum! cleanup

The single-thread branch was calling hadamard_sum! with a plain
SparseMatrixCSC (dg.basis.Drst[dim]), which matched the now-deleted
dense overload. Replace the call with an inlined symmetric sparse loop
identical in structure to the multithreaded branch, using -vals[id] to
recover A[i,j] from the stored A[j,i] (skew-symmetry of periodic D).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Restore upper-triangular comment in hadamard_sum! NonAffine overload

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* move `flux_differencing_kernel!` directly into volume_integral_kernel!

* add alpha=true to allow for accumulation in volume_integral_kernel!

* move `low_order_flux_differencing!` into `volume_integral_kernel!`

* comments

* move hadamard_sum functionality into l... (continued)

Coverage Stats

136 of 137 new or added lines in 5 files covered. (99.27%)

4688 existing lines in 151 files now uncovered.

41229 of 47269 relevant lines covered (87.22%)

34581006.27 hits per line