NVIDIA / holodeck / 23493993388

48%

push

github

fix: wait for NAT Gateway available state before creating routes (#735)

* fix: wait for NAT Gateway to reach available state before creating routes

CreateNatGateway returns immediately with a pending NAT Gateway ID.
Using this ID in CreateRoute before the NAT GW is available causes
InvalidNatGatewayID.NotFound errors, breaking all cluster deployments.

Poll DescribeNatGateways until state transitions to available (or
failed) before returning from createNATGateway. This matches the
existing pattern in deleteNATGateway which polls for deleted state.

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

* fix: remove public IP assertion for cluster nodes in private subnet

In the production cluster topology all nodes are in the private subnet
and do not have public IPs. The E2E test was asserting PublicIP is
non-empty for all nodes, which fails by design. Only PrivateIP is
guaranteed.

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

* fix: wire SSM transport for private-subnet cluster nodes

Cluster nodes in private subnets have no public IP, so SSH connections
must go through SSM port-forwarding. The E2E test and GetClusterHealth
were building NodeInfo without setting the Transport field, causing SSH
to attempt direct connection to an empty host.

Wire SSMTransport for nodes with no PublicIP, matching the production
code path in buildClusterNodeInfoList.

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

* fix: place cluster instances in public subnet with public IPs

The private subnet topology (PR #728) moved cluster instances behind
a NAT GW, but SSM infrastructure (IAM instance profiles) was never
set up, making SSH connections impossible. Revert instances to the
public subnet with AssociatePublicIpAddress=true so they are directly
reachable via SSH. The NAT GW + NLB infrastructure remains in place
for future SSM migration.

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.c... (continued)

93 of 126 new or added lines in 4 files covered. (73.81%)

3724 of 6613 relevant lines covered (56.31%)

0.63 hits per line