hyperledger / fabric-x-committer / 23486001637

91%

Build Type

push

github

Committed by web-flow

Commit Message

Introduce UnmarshalEnvelopeLite to speed up mapBlock (#316)

#### Type of change

- Improvement (improvement to code, performance, etc)
 
#### Description

Replace full proto.Unmarshal of Envelope→Payload→ChannelHeader (3
chained
deserializations) with direct protobuf wire-format scanning that
extracts
  only the needed fields (HeaderType, TxID, Data). This reduces envelope
parsing from 287 ns/op to 72 ns/op — a 4x speedup with 7 fewer
allocations.
```
  BenchmarkUnwrapEnvelope-14        4079934    286.7 ns/op   616 B/op   9 allocs/op
  BenchmarkUnwrapEnvelopeLite-14   16929306     71.5 ns/op    72 B/op   2 allocs/op

  [New mapBlock]
  BenchmarkMapBlock/txs=500-14                   2850            400160 ns/op          663662 B/op      13579 allocs/op
  BenchmarkMapBlock/txs=500-14                   2599            405622 ns/op          664974 B/op      13594 allocs/op
  BenchmarkMapBlock/txs=500-14                   2767            408145 ns/op          657391 B/op      13505 allocs/op

  [Old mapBlock]
  BenchmarkMapBlock/txs=500-14                   1497            677487 ns/op         1165977 B/op      17648 allocs/op
  BenchmarkMapBlock/txs=500-14                   1584            659822 ns/op         1168212 B/op      17674 allocs/op
  BenchmarkMapBlock/txs=500-14                   1808            635695 ns/op         1158503 B/op      17561 allocs/op
```
With UnmarshalEnvelopeLite, the new mapBlock is able to process 1.7x
more blocks.

#### Related issues

  - partially addresses #306

---------

Signed-off-by: Senthilnathan <cendhu@gmail.com>

Run Details

92 of 116 new or added lines in 2 files covered. (79.31%)

16 existing lines in 6 files now uncovered.

9632 of 10642 relevant lines covered (90.51%)

1.35 hits per line