23481878026

Committed 24 Mar 2026 09:16AM UTC coverage: 57.133% (+0.01%) from 57.121%

Build # 23481878026

Build Type

push

github

Committed by

web-flow

Commit Message

Bugfix/fix merge issue (#2326)

* fix merge and update trigger

* tidy up

Coverage Stats

11547 of 21743 branches covered (53.11%)

Branch coverage included in aggregate %.

19 of 27 new or added lines in 7 files covered. (70.37%)

5 existing lines in 4 files now uncovered.

32671 of 55652 relevant lines covered (58.71%)

18121.93 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/Rdmp.Core/DataLoad/Triggers/Implementations/OracleTriggerImplementer.cs

// Copyright (c) The University of Dundee 2018-2019
// This file is part of the Research Data Management Platform (RDMP).
// RDMP is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.
// RDMP is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.
// You should have received a copy of the GNU General Public License along with RDMP. If not, see <https://www.gnu.org/licenses/>.

using System.Linq;
using FAnsi.Discovery;
using FAnsi.Discovery.QuerySyntax;
using Oracle.ManagedDataAccess.Client;
using Rdmp.Core.ReusableLibraryCode.Exceptions;
using Rdmp.Core.ReusableLibraryCode.Settings;

namespace Rdmp.Core.DataLoad.Triggers.Implementations;

/// <inheritdoc/>
internal class OracleTriggerImplementer : MySqlTriggerImplementer
{
    /// <inheritdoc cref="TriggerImplementer(DiscoveredTable,bool,bool)"/>
    public OracleTriggerImplementer(DiscoveredTable table, bool createDataLoadRunIDAlso = true,bool dontAddDataLoadrunID=false) : base(table,
        createDataLoadRunIDAlso)
    {
    }

    protected override string GetTriggerBody()
    {
        using var con = _server.GetConnection();
        con.Open();

        using var cmd =
            _server.GetCommand(
                $"select trigger_body from all_triggers where trigger_name = UPPER('{GetTriggerName()}')", con);
        ((OracleCommand)cmd).InitialLONGFetchSize = -1;
        var r = cmd.ExecuteReader();

        while (r.Read())
            return (string)r["trigger_body"];

        return null;
    }

    protected override void AddValidFrom(DiscoveredTable table, IQuerySyntaxHelper syntaxHelper)
    {
        _table.AddColumn(SpecialFieldNames.ValidFrom, " DATE DEFAULT CURRENT_TIMESTAMP", true,
            UserSettings.ArchiveTriggerTimeout);
    }

    protected override string CreateTriggerBody()
    {
        var syntax = _table.GetQuerySyntaxHelper();

        return $@"BEGIN
    INSERT INTO {_archiveTable.GetFullyQualifiedName()} ({string.Join(",", _columns.Where(c => _dontAddDataLoadRunId?c.GetRuntimeName() != SpecialFieldNames.DataLoadRunID:true).Select(c => syntax.EnsureWrapped(c.GetRuntimeName())))},hic_validTo,hic_userID,hic_status) VALUES ({string.Join(",", _columns.Select(c => $":old.{syntax.EnsureWrapped(c.GetRuntimeName())}"))},CURRENT_DATE,USER,'U');

  :new.{syntax.EnsureWrapped(SpecialFieldNames.ValidFrom)} := sysdate;


  END";
    }

    protected override void AssertTriggerBodiesAreEqual(string sqlThen, string sqlNow)
    {
        sqlNow ??= "";
        sqlThen ??= "";

        if (!sqlNow.Trim(';', ' ', '\t').Equals(sqlThen.Trim(';', ' ', '\t')))
            throw new ExpectedIdenticalStringsException("Sql body for trigger doesn't match expected sql", sqlThen,
                sqlNow);
    }
}

1	// Copyright (c) The University of Dundee 2018-2019
2	// This file is part of the Research Data Management Platform (RDMP).
3	// RDMP is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.
4	// RDMP is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.
5	// You should have received a copy of the GNU General Public License along with RDMP. If not, see <https://www.gnu.org/licenses/>.
6
7	using System.Linq;
8	using FAnsi.Discovery;
9	using FAnsi.Discovery.QuerySyntax;
10	using Oracle.ManagedDataAccess.Client;
11	using Rdmp.Core.ReusableLibraryCode.Exceptions;
12	using Rdmp.Core.ReusableLibraryCode.Settings;
13
14	namespace Rdmp.Core.DataLoad.Triggers.Implementations;
15
16	/// <inheritdoc/>
17	internal class OracleTriggerImplementer : MySqlTriggerImplementer
18	{
19	/// <inheritdoc cref="TriggerImplementer(DiscoveredTable,bool,bool)"/>
NEW 20	public OracleTriggerImplementer(DiscoveredTable table, bool createDataLoadRunIDAlso = true,bool dontAddDataLoadrunID=false) : base(table,	×
UNCOV 21	createDataLoadRunIDAlso)	×
22	{
23	}	×
24
25	protected override string GetTriggerBody()
26	{
27	using var con = _server.GetConnection();	×
28	con.Open();	×
29
30	using var cmd =	×
31	_server.GetCommand(	×
32	$"select trigger_body from all_triggers where trigger_name = UPPER('{GetTriggerName()}')", con);	×
33	((OracleCommand)cmd).InitialLONGFetchSize = -1;	×
34	var r = cmd.ExecuteReader();	×
35
36	while (r.Read())	×
37	return (string)r["trigger_body"];	×
38
39	return null;	×
40	}	×
41
42	protected override void AddValidFrom(DiscoveredTable table, IQuerySyntaxHelper syntaxHelper)
43	{
44	_table.AddColumn(SpecialFieldNames.ValidFrom, " DATE DEFAULT CURRENT_TIMESTAMP", true,	×
45	UserSettings.ArchiveTriggerTimeout);	×
46	}	×
47
48	protected override string CreateTriggerBody()
49	{
50	var syntax = _table.GetQuerySyntaxHelper();	×
51
52	return $@"BEGIN	×
NEW 53	INSERT INTO {_archiveTable.GetFullyQualifiedName()} ({string.Join(",", _columns.Where(c => _dontAddDataLoadRunId?c.GetRuntimeName() != SpecialFieldNames.DataLoadRunID:true).Select(c => syntax.EnsureWrapped(c.GetRuntimeName())))},hic_validTo,hic_userID,hic_status) VALUES ({string.Join(",", _columns.Select(c => $":old.{syntax.EnsureWrapped(c.GetRuntimeName())}"))},CURRENT_DATE,USER,'U');	×
54		×
55	:new.{syntax.EnsureWrapped(SpecialFieldNames.ValidFrom)} := sysdate;	×
56		×
57		×
58	END";	×
59	}
60
61	protected override void AssertTriggerBodiesAreEqual(string sqlThen, string sqlNow)
62	{
63	sqlNow ??= "";	×
64	sqlThen ??= "";	×
65
66	if (!sqlNow.Trim(';', ' ', '\t').Equals(sqlThen.Trim(';', ' ', '\t')))	×
67	throw new ExpectedIdenticalStringsException("Sql body for trigger doesn't match expected sql", sqlThen,	×
68	sqlNow);	×
69	}	×
70	}

HicServices / RDMP / 23481878026

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous