kubeovn / kube-ovn / 23479723791

27%

Build Type

push

github

Committed by web-flow

Commit Message

fix(daemon): use multiple KubeVirt labels for VM launcher pod lookup (#6512)

* fix(daemon): use multiple KubeVirt labels for VM launcher pod lookup

The gcInterfaces() function only used the deprecated vm.kubevirt.io/name
label to find launcher pods for KubeVirt VMs. This label is unreliable
when VMs have custom hostnames set (spec.template.spec.hostname), as
KubeVirt copies the hostname instead of the VM name into the label.
This could cause OVS interfaces to be incorrectly garbage collected.

Extract isVMLauncherPodAlive() with a three-tier lookup strategy:
1. vmi.kubevirt.io/id label (unique, KubeVirt >= 1.7)
2. vm.kubevirt.io/name label (fallback for older KubeVirt)
3. kubevirt.io/domain annotation (handles VMI names > 63 chars)

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

* fix(daemon): rename podName to vmiName and support cached pod list

Address review feedback:
- Rename podName parameter to vmiName for clarity since OVS
  external_ids stores the VMI name, not the Kubernetes pod name
- Accept optional pre-fetched pod list for annotation fallback to
  avoid repeated List(labels.Everything()) calls in a loop
- Update log messages to use "vmi" instead of "vm"

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

* fix(daemon): simplify isVMLauncherPodAlive by removing namespacePods parameter

Remove the optional pre-fetched pod list parameter. Instead, use a
label selector with DeprecatedVirtualMachineNameLabel Exists requirement
to narrow down candidates to virt-launcher pods only in the annotation
fallback, avoiding a full namespace pod scan.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <li... (continued)

Coverage Stats

31 of 43 new or added lines in 1 file covered. (72.09%)

1 existing line in 1 file now uncovered.

13169 of 55194 relevant lines covered (23.86%)

0.28 hits per line