Alan-Jowett / sonde / 23470871213

82%

Build Type

push

github

Committed by web-flow

Commit Message

fix(modem,pair): BLE scan filter and GATT auth regressions (#441)

* fix(modem,pair): BLE scan filter and GATT auth regressions

- btleplug WinRT: use empty ScanFilter — WinRT advertisement watcher
  does not match 16-bit UUIDs passed as 128-bit in the filter. Filtering
  is done in the discovery layer instead.

- btleplug connect: run a short pre-connect scan when the target
  peripheral is not in the adapter's cache (new transport instance).

- btleplug \pairing_method()\: return \None\ (OS-enforced) instead of
  \Some(Unknown)\ — btleplug delegates pairing to the OS stack, so
  \nforce_lesc\ should treat it as OS-managed security.

- modem GATT characteristic (0xFE61): add \WRITE_ENC | WRITE_AUTHEN\
  permissions so the OS BLE stack triggers LESC Numeric Comparison
  pairing before the first GATT write (MD-0404).

- Add stderr tracing layer to sonde-pair-ui for debugging.
- Add debug logging to BLE discovery and scan paths.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix(modem): server-initiated LESC pairing on connect

Revert GATT WRITE_ENC/WRITE_AUTHEN permissions — btleplug/WinRT does
not auto-pair when the server rejects with 'insufficient auth'.

Instead, call \le_gap_security_initiate()\ from the \on_connect\
callback so the modem proactively starts LESC Numeric Comparison
pairing immediately after a client connects (MD-0404).  This ensures
pairing happens regardless of whether the client initiates it.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* docs: server-initiated LESC pairing across spec trifecta

Requirements (MD-0404):
- Add criterion 5: modem MUST call \le_gap_security_initiate\ in
  \on_connect\ to ensure pairing regardless of client behavior.
- Update description to specify server-initiated pairing.

Design (modem-design.md §15.2):
- Add step 1: \le_gap_security_initiate(conn_handle)\ in the pairing
  sequence, renumber subsequent steps.

Validation (modem-validation.md):... (continued)

Coverage Stats

5 of 60 new or added lines in 4 files covered. (8.33%)

2 existing lines in 2 files now uncovered.

21450 of 24985 relevant lines covered (85.85%)

164.44 hits per line