Alan-Jowett / sonde / 23456573279

82%

push

github

feat(sonde-pair): add LESC pairing enforcement, BLE fragmentation, and missing tests (#422)

* feat(sonde-pair): add LESC pairing enforcement, BLE fragmentation, and missing tests

Closes #340 — addresses all four gaps identified in the validation audit.

GAP 1 — LESC Numeric Comparison enforcement (PT-0904):
- Add PairingMethod enum (NumericComparison, JustWorks) to 	ypes.rs
- Add pairing_method() to BleTransport trait with default None impl
- Enforce LESC in phase1::pair_with_gateway and phase2::provision_node
  (reject JustWorks with InsecurePairingMethod error before any GATT writes)
- Update MockBleTransport with configurable pairing_method and ail_connect
- Tests: T-PT-109, T-PT-804, T-PT-805 (Phase 1 and Phase 2)

GAP 2 — BLE indication reassembly and Write Long fragmentation (§3.4):
- Add ragmentation.rs module with ragment_for_write() and
  IndicationReassembler (stateful multi-chunk reassembly using envelope
  header LEN field)
- 14 tests covering: single/multi-chunk writes, exact boundaries, empty
  data, single/multi-chunk reassembly, byte-at-a-time, overflow rejection,
  empty chunk rejection, header split across chunks, zero-length payload,
  MTU-244 boundary, consecutive messages, and reset behavior

GAP 3 — PT-0902 traceability (validation doc):
- Fix T-PT-309 \Validates:\ line: \PT-0405\ → \PT-0405, PT-0902\
  (traceability table already correct, spec body was not)

GAP 4 — Verbose diagnostic mode (PT-0702):
- T-PT-112: assert message type names (REQUEST_GW_INFO, GW_INFO_RESPONSE,
  REGISTER_PHONE) appear in trace output and PSK hex never does

Additional:
- T-PT-309: Ed25519 → X25519 low-order point rejection test in \crypto.rs\

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Add pre-allocation size guard and make pairing_method required

- fragmentation: check buffer + chunk size against MAX_REASSEMBLY_SIZE
  before extending the buffer, preventing unbounded allocation from a
  large first chunk.
- transp... (continued)

453 of 484 new or added lines in 8 files covered. (93.6%)

18928 of 22380 relevant lines covered (84.58%)

46.96 hits per line