Alan-Jowett / sonde / 23456258630
82%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 73
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 84.394% (+0.02%) from 84.379%
23456258630

push

github

web-flow 
fix(protocol): remove redundant `command_type` from `GatewayMessage::Command` (#426)

* fix(protocol): remove redundant command_type from GatewayMessage::Command

Remove the EncodeError::CommandTypeMismatch variant — it was dead code
since command_type is derived from CommandPayload::command_type(),
making a mismatch structurally impossible.

Update design doc §6.2 to remove the stale command_type: u8 field from
the GatewayMessage::Command definition, aligning the spec with the
implementation.

Add T-P063 test verifying CommandPayload::command_type() returns the
correct wire code for all five variants and round-trips through
encode/decode.

Mark audit findings F-010 (trifecta) and F-003 (code-compliance) as
resolved.

Closes #375

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: address review comments on audit doc wording

- Label F-010 evidence block as 'before remediation' to avoid confusion
  with the updated design §6.2.
- Clarify undocumented-behaviors summary to separate open vs resolved
  counts.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: renumber T-P063 to T-P090 and fix stale code location

Rename command_type derivation test from T-P063 to T-P090 to avoid
collision with the existing T-P063 (direction-bit cross-direction
rejection) in protocol-crate-validation.md.

Update the resolved finding code location to omit the now-stale
line number, marking it as pre-#375.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

18511 of 21934 relevant lines covered (84.39%)

48.58 hits per line

Coverage Regressions

Lines Coverage ∆ File
1
0.0
 0.0% crates/sonde-protocol/src/error.rs
Jobs
ID Job ID Ran Files Coverage
1 23456258630.1 73
84.39
 GitHub Action Run
Source Files on build 23456258630