23455543725
96%

Ran 23 Mar 2026 07:14PM UTC

Jobs 8

Files 144

Run time 1min

Badge

Embed ▾

Committed 23 Mar 2026 07:08PM UTC coverage: 96.471% (-0.03%) from 96.503%

Build # 23455543725

Build Type

push

github

Committed by

Matoking

Commit Message

Fix disabled Flatpak filesystem permission check

Return all found Steam library paths in `get_steam_lib_paths`, even
those not found in the filesystem.

Due to earlier refactoring, the function checked which directories were
accessible in the filesystem and only returned those. The return value
was used by `prompt_filesystem_access`; any paths were obviously
already accessible in the sandbox, meaning the function would never find
any inaccessible paths and prompt the user.

Also add new regression test that tests this behavior by running an
actual Protontricks command while mocking the Python FS call to hide the
directory. An existing unit test for the Flatpak permission check was
insufficient as it only tested the prompt check in isolation with a
hardcoded list of paths.

Fixes #472

Run Details

12792 of 13260 relevant lines covered (96.47%)

0.96 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
17	94.98	0.0%	opt/hostedtoolcache/Python/3.10.20/x64/lib/python3.10/site-packages/protontricks/steam.py
17	94.98	0.0%	opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/protontricks/steam.py
17	94.98	0.0%	opt/hostedtoolcache/Python/3.13.12/x64/lib/python3.13/site-packages/protontricks/steam.py
17	94.98	0.0%	opt/hostedtoolcache/Python/3.12.13/x64/lib/python3.12/site-packages/protontricks/steam.py
17	94.93	0.0%	opt/hostedtoolcache/Python/3.7.17/x64/lib/python3.7/site-packages/protontricks/steam.py
17	94.95	0.0%	opt/hostedtoolcache/Python/3.9.25/x64/lib/python3.9/site-packages/protontricks/steam.py
17	94.95	0.0%	opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/protontricks/steam.py
17	94.98	0.0%	opt/hostedtoolcache/Python/3.14.3/x64/lib/python3.14/site-packages/protontricks/steam.py

Jobs

ID	Job ID	Ran	Files	Coverage
1	23455543725.1	23 Mar 2026 07:14PM UTC	18	96.52	GitHub Action Run
2	23455543725.2	23 Mar 2026 07:14PM UTC	18	96.52	GitHub Action Run
3	23455543725.3	23 Mar 2026 07:14PM UTC	18	96.52	GitHub Action Run
4	23455543725.4	23 Mar 2026 07:14PM UTC	18	96.52	GitHub Action Run
5	23455543725.5	23 Mar 2026 07:14PM UTC	18	96.45	GitHub Action Run
6	23455543725.6	23 Mar 2026 07:14PM UTC	18	96.48	GitHub Action Run
7	23455543725.7	23 Mar 2026 07:14PM UTC	18	96.25	GitHub Action Run
8	23455543725.8	23 Mar 2026 07:14PM UTC	18	96.52	GitHub Action Run

Matoking / protontricks / 23455543725
96%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 23455543725

Matoking / protontricks / 23455543725 96%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 23455543725

Matoking / protontricks / 23455543725
96%

README BADGES
x