Alan-Jowett / sonde / 23453856371
82%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 73
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 84.341% (+0.005%) from 84.336%
23453856371

push

github

web-flow 
test(protocol): close 4 validation gaps — direction-bit, nonce echo, multi-APP_DATA, HMAC (T-P063..T-P068) (#406)

* test(protocol): add validation gap tests for direction-bit, nonce echo, multi-APP_DATA, and HMAC (T-P063..T-P066)

Close four protocol validation gaps identified in issue #347:

1. Direction-bit cross-direction rejection (T-P063):
   - `NodeMessage::decode` rejects all gateway msg_types (0x81-0x84)
   - `GatewayMessage::decode` rejects all node msg_types (0x01-0x05)

2. Nonce echo verification (T-P064):
   - WAKE -> COMMAND: COMMAND frame echoes the WAKE nonce
   - Negative case: mismatched nonce is detectable by comparison

3. Multiple APP_DATA per wake cycle (T-P065):
   - Encodes/decodes 3 APP_DATA frames with incrementing nonces
     and verifies round-trip fidelity of each sequence value

4. HMAC constant-time comparison behavior (T-P066):
   - Exercises `SoftwareHmac::verify` directly with correct and
     single-bit-flipped tags.  Constant-time guarantee comes from
     `hmac::Mac::verify_slice` (enforced via code review per
     protocol-crate-validation.md T-P066).

Closes #347

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: align test IDs T-P063..T-P068 with PR description and expand HMAC coverage

- Split direction-bit test into T-P063 (NodeMessage) and T-P064 (GatewayMessage)
- Renumber nonce echo test to T-P065 (WAKE→COMMAND)
- Add T-P066: GET_CHUNK→CHUNK and APP_DATA→APP_DATA_REPLY nonce binding
- Renumber multiple APP_DATA test to T-P067
- Renumber HMAC test to T-P068 and add all-zero, last-byte flip,
  wrong-data, and wrong-key corruption scenarios

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: T-P067 now encodes 5 APP_DATA frames with monotonic check

Expand T-P067 from 3 to 5 payloads and add an explicit strict
monotonic ordering assertion as described in the PR specification.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: clari... (continued)

18404 of 21821 relevant lines covered (84.34%)

48.69 hits per line

Jobs
ID Job ID Ran Files Coverage
1 23453856371.1 73
84.34
 GitHub Action Run
Source Files on build 23453856371