Alan-Jowett / sonde / 23449318902

82%

push

github

Add pairing tool reliability and error recovery tests (8 gaps) (#421)

* Add pairing tool reliability and error recovery tests (8 gaps)

Close all 8 validation gaps from issue #341:

1. PT-1003 — No implicit retries: tests verify exactly one GATT
   write/read attempt per operation (Phase 1 and Phase 2).

2. PT-1000 — Transient failure tolerance: Phase 2 mid-provision
   disconnect test (`ConnectionDropped` during `NODE_ACK` read),
   plus retry-after-failure verification.

3. PT-1002 — Connection timeout exercised: inject `Timeout` error
   from `connect()` in both Phase 1 and Phase 2.

4. PT-0502 — BLE disconnect on error paths: assert
   `transport.connected == false` and `disconnect_count > 0`
   after Phase 1 and Phase 2 failures.

5. PT-1001 — Resource leaks: 10 Phase 1 and 8 Phase 2 consecutive
   failure scenarios with post-failure connection state assertion.

6. PT-0801 — Platform secure storage: DPAPI round-trip, tamper
   detection, and distinct-key tests (`#[cfg(windows)]`).

7. PT-1004 — Reusable core: compile-time test exercising core types,
   store, transport, envelope, crypto, and validation without any
   platform feature flags.

8. PT-1100/PT-1200–PT-1206 — Traceability: add PT-1000–PT-1004 and
   PT-1100 to the meta-requirement traceability table; add T-PT-1004
   to Appendix A.

MockBleTransport gains `connect_error`, `write_error`, and
`disconnect_count` fields for error injection and resource-leak
verification.

Closes #341

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: record write attempts on error, add read_call_count, update test IDs

- MockBleTransport: record writes before checking write_error so tests
  can assert exact attempt counts even on injected failures
- MockBleTransport: add read_call_count field to track read_indication
  calls for no-retry verification
- Phase 1 / Phase 2 PT-1003 tests: assert write attempt count and
  read_call_count to detect implicit retries
- DPAPI tests: reas... (continued)

508 of 510 new or added lines in 4 files covered. (99.61%)

18402 of 21821 relevant lines covered (84.33%)

48.44 hits per line