Gallopsled / pwntools / 23447622211

74%

push

github

Fix `server.close()` not closing the listen socket (#2682)

* Fix `server.close()` not closing the listen socket

It would block on `accept` forever, not freeing the listening port.
Break out of `accept()` regularly to check if the socket was closed in the meantime and stop the thread.

* Update CHANGELOG

* Fix `listen.close()` not closing the listen socket

If `close()` was called before a connection was accepted,
the listen socket would not be closed.

* Fix closing listen socket on Windows

Windows throws an ENOTSOCK instead of an EBADF.

* Keep timeout on child socket tube

3877 of 6532 branches covered (59.35%)

12 of 16 new or added lines in 2 files covered. (75.0%)

13389 of 18183 relevant lines covered (73.63%)

0.74 hits per line