wol-soft / php-json-schema-model-generator / 23444910203

Pull #115

github

Address PR #115 review comments

- Rename ConditionalPropertyValidator $dataBranches → $conditionBranches /
  getDataBranches() → getConditionBranches() for clarity
- Simplify cloneTransferredProperty: drop explicit $compositionProcessor param,
  derive it from $validator internally
- Total-conflict detection: throw SchemaException when ALL anyOf/oneOf/if-then-else
  branches define a property with a type that conflicts with the root type;
  add three new schema fixtures and tests for this behaviour
- Extract FilterProcessor::normalizeFilterList() static helper; use it in both
  FilterProcessor::process() and patternHasTransformingFilter() to remove duplication
- Remove TypeCheckValidator filter in PropertyNamesValidator (redundant with
  composition branch validation)
- Rename $p → $compositionProperty in AbstractComposedValueProcessor lambdas;
  remove phase-number comments
- Inline $propertyType and rename $t → $type in MultiTypeProcessor
- Unify duplicate note+hint blocks in allOf/anyOf/oneOf RST docs into single notes
  with cross-links; add patternProperties note to crossTypedComposition
- Fix PropertyType docblock alignment; remove temporary analysis file;
  fix trailing-comma and import style nits across several files
- Replace generic ValidationException with specific AllOfException/AnyOfException/
  OneOfException in CrossTypedCompositionTest; remove issue-number from docblock
- Remove TypeError test blocks from AdditionalPropertiesAccessorPostProcessorTest
  (setter has native union type hint, TypeError is now the expected normal behaviour)
- Add Schema::getPropertyMerger() accessor

540 of 550 new or added lines in 51 files covered. (98.18%)

3884 of 3939 relevant lines covered (98.6%)

546.53 hits per line