• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

kubeovn / kube-ovn / 23435480747
27%

Build:
DEFAULT BRANCH: master
Ran 23 Mar 2026 11:41AM UTC
Jobs 1
Files 205
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

23 Mar 2026 11:39AM UTC coverage: 23.819% (+0.03%) from 23.792%
23435480747

push

github

web-flow
fix(controller): filter empty VIP strings from SwitchLBRule annotation (#6507)

* fix(controller): filter empty VIP strings from SwitchLBRule annotation

When the SwitchLBRuleVipsAnnotation exists but has an empty value,
strings.Split("", ",") returns [""] (a slice with one empty string),
which propagates to OVN LB operations as invalid ":port" addresses.

Fix all affected code paths:
- getVipIps: filter empty strings when splitting the annotation value
- enqueueDeleteService: refactor to reuse getVipIps instead of
  duplicating the split logic
- handleUpdateService: skip SLR lookup when annotation value is empty
- handleUpdateEndpointSlice: skip VIP processing when annotation is empty
- handleAddOrUpdateSwitchLBRule: early return when Spec.Vip is empty

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

* fix(controller): filter empty ingress IP in getVipIps

Address review feedback: LoadBalancer ingress entries may have empty IP
(e.g. hostname-only), which would propagate as invalid ":port" VIPs.
Add empty IP check before appending ingress IPs, and add a test case
covering hostname-only and empty ingress entries.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

---------

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

7 of 15 new or added lines in 3 files covered. (46.67%)

13138 of 55157 relevant lines covered (23.82%)

0.28 hits per line

Uncovered Changes

Lines Coverage ∆ File
4
6.15
-0.06% pkg/controller/switch_lb_rule.go
3
3.51
3.51% pkg/controller/service.go
1
17.24
0.0% pkg/controller/endpoint_slice.go
Jobs
ID Job ID Ran Files Coverage
1 23435480747.1 23 Mar 2026 11:41AM UTC 205
23.82
GitHub Action Run
Source Files on build 23435480747
  • Tree
  • List 205
  • Changed 2
  • Source Changed 0
  • Coverage Changed 2
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • 119adbaa on github
  • Prev Build on master (#23433366051)
  • Next Build on master (#23438611596)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc