kubeovn / kube-ovn / 23435480747

27%

push

github

fix(controller): filter empty VIP strings from SwitchLBRule annotation (#6507)

* fix(controller): filter empty VIP strings from SwitchLBRule annotation

When the SwitchLBRuleVipsAnnotation exists but has an empty value,
strings.Split("", ",") returns [""] (a slice with one empty string),
which propagates to OVN LB operations as invalid ":port" addresses.

Fix all affected code paths:
- getVipIps: filter empty strings when splitting the annotation value
- enqueueDeleteService: refactor to reuse getVipIps instead of
  duplicating the split logic
- handleUpdateService: skip SLR lookup when annotation value is empty
- handleUpdateEndpointSlice: skip VIP processing when annotation is empty
- handleAddOrUpdateSwitchLBRule: early return when Spec.Vip is empty

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

* fix(controller): filter empty ingress IP in getVipIps

Address review feedback: LoadBalancer ingress entries may have empty IP
(e.g. hostname-only), which would propagate as invalid ":port" VIPs.
Add empty IP check before appending ingress IPs, and add a test case
covering hostname-only and empty ingress entries.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

---------

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

7 of 15 new or added lines in 3 files covered. (46.67%)

13138 of 55157 relevant lines covered (23.82%)

0.28 hits per line