hyperledger / fabric-x-common / 23434305087

82%

push

github

[grpc logger] reduce GRPC log level by default for tests (#95)

#### Type of change

- Bug fix
- Test update

#### Description

- This PR adds `-race` flag for the tests and fix the race conditions
- Fix minor race condition in test
- Use `gotestsum` to shorten the logs
- Reduce GRPC log level by default using environment variable instead of
manually

**Root Cause Analysis: Two Data Races Fixed by This PR**

**1. Test Data Race in `TestLoadPrivateKey_BadPEM`**
- **Cause:** Multiple parallel subtests shared a parent-scope `err`
variable
- **Manifestation:** Write-write and read-write conflicts at lines 86-87
- **Fix:** Changed `_, err =` to `_, loadErr :=` to create local
variable per subtest

**2. gRPC Logger Initialization Race**
- **Cause:** `grpclog.SetLoggerV2()` is not thread-safe; multiple
goroutines could call it concurrently during package initialization
- **Manifestation:** Concurrent writes to gRPC's global logger state
when multiple packages import flogging simultaneously

#### Related issues

- https://github.com/hyperledger/fabric-x-committer/issues/448

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

8 of 8 new or added lines in 5 files covered. (100.0%)

14606 of 17764 relevant lines covered (82.22%)

0.92 hits per line