EsupPortail / Esup-Pod / 23433297814

69%

main: 71%

Build Type

push

github

Committed by web-flow

Commit Message

Fix Thumbnail Persistence and Completion Alert (#1409)

## Summary

This PR fixes a frontend safety issue and hardens the transcript/remote-encoding workflow to prevent unintended field overwrites.

## Changes

- Frontend (`completion.js`):
  - Safely remove `formalertdiv` only when it exists, preventing a client-side error in the error-rendering path.

- Backend (`video_encode_transcript`):
  - Replaced several full model `save()` calls with targeted `QuerySet.update()` calls for `encoding_in_progress`, `duration`, and `is_video`.
  - Prevented stale object saves from overwriting unrelated fields, especially `thumbnail`.
  - Added thumbnail persistence diagnostics (selected vs persisted thumbnail IDs).
  - Added a fallback thumbnail assignment path when persistence unexpectedly returns `NULL`.
  - Added warning logs when a thumbnail is still missing after remote import.

## Why

Using full-object saves in long workflows could overwrite fields set by other steps. This change reduces that risk and improves traceability when thumbnail persistence fails.

Coverage Stats

1 of 24 new or added lines in 3 files covered. (4.17%)

8 existing lines in 4 files now uncovered.

12922 of 18984 relevant lines covered (68.07%)

0.68 hits per line