scarver2 / ehr-portal / 23424365996

77%

push

github

feat(csrf): disable CSRF protection for localhost development tests (#38)

* fix(tests): add global localStorage mock for all portal tests

- Add localStorage implementation to vitest.setup.ts
- Provides getItem, setItem, removeItem, and clear methods
- Clears localStorage after each test to prevent test pollution
- Update useInsuranceVerificationStream tests to use localStorage API
- Replace Storage.prototype spies with direct localStorage calls
- All 156 portal tests now pass ✅

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

* fix: remove unused vi import from vitest.setup.ts

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

* refactor(i18n): move photo_url validation message to locale file

- Add photo_url_format error message to config/locales/en.yml
- Update Patient model validation to use I18n key :photo_url_format
- Update Provider model validation to use I18n key :photo_url_format
- Follows Rails best practices for internationalization
- Fixes RuboCop Rails/I18nLocaleTexts violations

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

* fix: use \A instead of ^ in photo_url regex validation

- Replace multiline anchor ^ with \A for string start
- Prevents regex injection security vulnerability
- Matches Rails security best practices for regex validators
- Fixes ArgumentError about multiline anchors

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

* fix(admin): remove global before_action that caused login redirect loop

- Remove config.before_action :require_admin_role from ActiveAdmin config
- This filter was being applied to all ActiveAdmin routes, including the login page
- Caused "too many redirects" error when visiting /admin/login
- Devise's authenticate_admin_user! already handles authentication
- Add note explaining that authorization should be per-resource instead

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

* fix(smoke): add error trap and verbose debug mode

- Add ERR trap to catch ... (continued)

137 of 256 branches covered (53.52%)

Branch coverage included in aggregate %.

209 of 312 relevant lines covered (66.99%)

6.86 hits per line