kubernetes-sigs / karpenter / 23423117482

80%

main: 80%

Build Type

Pull #2671

github

Committed by moko-poi

Commit Message

fix: use Compatible instead of Intersects for domain filtering

Intersects only checks keys common to both requirement sets, so a pod
requiring a custom label (e.g. workload-group=app) that is not defined
on a NodePool would still pass the check. Compatible with
AllowUndefinedWellKnownLabels correctly rejects NodePools that lack
the pod's required custom labels while still allowing well-known labels
(zone, arch, etc.) to be undefined at the NodePool level.

Pull Request Pull Request #2671: fix: Filter topology domains by NodePool compatibility with pod requirements

Run Details

90 of 92 new or added lines in 3 files covered. (97.83%)

6 existing lines in 2 files now uncovered.

12143 of 15112 relevant lines covered (80.35%)

229542.25 hits per line