agama-project / agama / 23416021186

Pull #3300

github

revert(web): use aria-label instead of LabelText hidden

Reverts the use of LabelText hidden for the DNS servers and DNS search
domains textareas. PatternFly's FormGroup reserves visual space for the
label area whenever a label prop is provided, even when its content is
visually hidden, leaving an unwanted gap in the layout.

Working around that with CSS overrides would be hacky and fragile for
little practical benefit in an application that manages its own
translations via _().

aria-label is used instead. It is widely supported and works correctly
in this context.

3284 of 5258 branches covered (62.46%)

Branch coverage included in aggregate %.

90 of 92 new or added lines in 4 files covered. (97.83%)

12848 of 16968 relevant lines covered (75.72%)

77.33 hits per line