agama-project / agama / 23401406723

Pull #3300

github

Add (optional) suffix to gateway fields

Gateway fields are only shown when the corresponding method is manual,
which might suggest they are always required when visible. However,
according to the NetworkManager documentation, the gateway is not
mandatory even in manual mode: it is only meaningful when addresses are
set, and can be replaced by an explicit default route.

Following the conventions in src/components/form/conventions.md, fields
that are conditionally shown but can still be left blank should carry the
(optional) suffix to make that clear to the user.

See: https://networkmanager.dev/docs/api/latest/settings-ip4-config.html

3274 of 5248 branches covered (62.39%)

Branch coverage included in aggregate %.

73 of 75 new or added lines in 3 files covered. (97.33%)

12814 of 16934 relevant lines covered (75.67%)

75.43 hits per line