kubeovn / kube-ovn / 23400945367

27%

push

github

refactor(controller): remove legacy svcMatchNetworkPolicies code (#6494)

* refactor(controller): remove legacy svcMatchNetworkPolicies code

All NetworkPolicy ACLs use apply-after-lb, which means ACL matching
occurs after LB/DNAT processing and sees real pod IPs rather than
Service ClusterIPs. Therefore, Service add/delete events do not affect
NP ACL content, making the svcMatchNetworkPolicies calls unnecessary.

Remove the following legacy code:
- svcMatchNetworkPolicies function from network_policy.go
- NP re-queue logic from enqueueAddService and enqueueDeleteService
- Dead "service" address set cleanup in handleDeleteNp (never created)

Also fix a minor log message: "enqueue add endpoint" -> "enqueue add service"

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

* fix(controller): differentiate duplicate log messages in enqueueAddService

Address review feedback: the two log lines in enqueueAddService used the
same message but enqueue different queues. Change the LB service log to
"enqueue add lb service" to distinguish from the endpoint slice enqueue.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

---------

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

0 of 2 new or added lines in 1 file covered. (0.0%)

13023 of 55158 relevant lines covered (23.61%)

0.28 hits per line