kubeovn / kube-ovn / 23396400685

27%

Build Type

push

github

Committed by web-flow

Commit Message

fix(controller): use consistent dual-stack check in subnet finalizer removal (#6492)

* fix(controller): use consistent dual-stack check in subnet finalizer removal

handleSubnetFinalizer only checked V4UsingIPs for dual-stack subnets
because CheckProtocol returns "Dual" (not "IPv6"), causing V6UsingIPs
to be ignored. This could lead to premature finalizer removal and
subnet deletion while IPv6 IPs were still in use.

Replace the inconsistent inline logic with a call to
readyToRemoveFinalizer, which correctly sums V4+V6 using IPs and
properly handles U2O interconnection IPs for both protocols.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

* test(controller): add unit tests for readyToRemoveFinalizer

Cover dual-stack, U2O interconnection, and edge cases to prevent
regressions in subnet finalizer removal logic.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

---------

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Coverage Stats

0 of 1 new or added line in 1 file covered. (0.0%)

197 existing lines in 1 file now uncovered.

13019 of 55207 relevant lines covered (23.58%)

0.28 hits per line