kubeovn / kube-ovn / 23382222605

27%

Build Type

push

github

Committed by web-flow

Commit Message

fix(controller): handle restartable init containers in DeleteNamedPortByPod (#6486)

* fix(controller): handle restartable init containers in DeleteNamedPortByPod

AddNamedPortByPod iterates over both restartable init containers (sidecar)
and regular containers, but DeleteNamedPortByPod only iterated over regular
containers. This caused named ports from sidecar init containers to leak
in namedPortMap after pod deletion.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

* fix(controller): use len() check for container ports consistency

Use `len(container.Ports) == 0` instead of `container.Ports == nil` in
DeleteNamedPortByPod to be consistent with AddNamedPortByPod, correctly
handling both nil and empty slices.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

---------

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Coverage Stats

10 of 10 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

12979 of 55213 relevant lines covered (23.51%)

0.27 hits per line