kubeovn / kube-ovn / 23379748527

27%

push

github

fix(controller): prevent panics from nil deref and data races in pod controller (#6483)

* fix(controller): prevent panics from nil dereference and data races in pod controller

Fix four panic-causing bugs in pkg/controller/pod.go:

1. Store last known pod instead of nil in deletingPodObjMap when pod
   Get returns NotFound during reconcileAllocateSubnets, preventing
   nil pointer dereference in handleDeletePod.

2. Return a shallow copy of the internal map in GetNamedPortByNs
   instead of the direct reference, preventing concurrent map
   read/write panic when NetworkPolicy reconciliation races with
   pod add/delete.

3. Replace direct c.ipam.Subnets map access in syncKubeOvnNet with
   c.ipam.ReleaseAddressByNic() which properly acquires the IPAM
   mutex, preventing data race panic during network hot-plug/unplug.

4. Add missing error return in appendCheckPodNetToDel after failed
   StatefulSet/VirtualMachine Get (non-NotFound errors), preventing
   nil pointer dereference panic on transient API server errors.
   Also simplify the subsequent nil check for VirtualMachine since
   it is guaranteed non-nil after the early error return.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

* fix(controller): use namespaced key for IPAM release and add unit test

Address review feedback:
- Use namespaced key (namespace/podName) instead of bare podName when
  calling ReleaseAddressByNic in syncKubeOvnNet, matching the key format
  used during IPAM allocation to ensure addresses are properly released.
- Add unit test for GetNamedPortByNs copy semantics to prevent
  reintroducing the concurrent map panic.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

* refactor(controller): simplify GetNamedPortByNs with... (continued)

2 of 8 new or added lines in 1 file covered. (25.0%)

12935 of 55214 relevant lines covered (23.43%)

0.27 hits per line