databendlabs / openraft / 23372170847

86%

Build Type

push

github

Committed by drmingdrmer

Commit Message

fix: remove incorrect is_voter check from current_leader()

In OpenRaft, a leader does not need to be a voter — following Paxos
semantics, a committed vote alone determines leadership. The is_voter()
check in current_leader() contradicted this design: calc_server_state()
correctly reports ServerState::Leader for a non-voter leader, but
current_leader() returned None, causing inconsistent metrics.

The fix removes the membership check entirely. A committed vote is the
sole authority on who the leader is.

The test check_learner_after_leader_transferred is updated to query a
node in the new cluster for the leader, since the demoted old leader
now correctly reports itself as leader per its stale committed vote.

- Fix: #1693

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

4 existing lines in 2 files now uncovered.

16013 of 18586 relevant lines covered (86.16%)

147647.18 hits per line