wol-soft / php-json-schema-model-generator / 23368127510

Pull #115

github

Refactor PropertyMerger public API for clarity and reduced parameter count

- Replace ?string $compositionProcessor with bool $isAllOf in merge(),
  removing the stringly-typed is_a() check from PropertyMerger itself
- Split narrowToIntersection() (8 params) into two focused methods:
  narrowToIntersection(existing, incoming, message) for allOf branch merging
  with nullable-preservation semantics, and applyTypeConstraint(existing,
  constraintType, message) for strict patternProperties enforcement
- Move $implicitNull derivation inside PropertyMerger (read from
  $generatorConfiguration directly) instead of requiring callers to pass it
- Replace $existingProperty/$incomingProperty params with bool $isRequired
  in buildEffectiveTypeSet, removing the PropertyInterface dependency
- Extract resolveEffectiveIntersection() to eliminate the duplicated
  validation + effective-set computation shared by both public methods
- Inline applyAllOfIntersection() which had become a trivial one-liner

481 of 491 new or added lines in 51 files covered. (97.96%)

3831 of 3886 relevant lines covered (98.58%)

549.13 hits per line