skeema / skeema / 23366541849

92%

push

github

internal: remove more introspection regexes

This commit continues the occasional ongoing effort of removing unnecessary
regular expressions from various older code paths. This one focuses on a few
table introspection fixup methods, where information_schema data is
problematic, so SHOW CREATE TABLE must be parsed instead:

* CHECK constraint expressions in MySQL 8+, which are always mangled by the
  server due to bad escaping
* CHECK constraint expressions in old patch releases of MariaDB 10.2-10.5,
  which are truncated at 64 characters in information_schema
* Table create options in MySQL 8+, which use a different ordering in SHOW
  CREATE TABLE vs information_schema

All of these were previously handled using dynamically-compiled regular
expressions, but are now handled using simpler calls from the strings package
instead.

No changes to user-facing behavior in this commit.

39 of 51 new or added lines in 3 files covered. (76.47%)

10830 of 11716 relevant lines covered (92.44%)

1.11 hits per line