medplum / medplum / 23365704211

92%

push

github

Various server cleanups (#8737)

* Extract isRetryableTransactionError to sql.ts and fix nested txn retry

Move isRetryableTransactionError from a private Repository method to a
standalone exported function in sql.ts. The retry check in withTransaction
now explicitly checks transactionDepth before calling the function,
correctly preventing retry attempts for nested transactions (savepoints).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Matt Long <ml@medplum.com>

* Minor cleanups: ES6 shorthand and type narrowing

Use ES6 property shorthand for projectId in external.ts. Narrow
createProjectMembership parameter from Repository to SystemRepository,
which better reflects intended usage (all callers already pass a
SystemRepository).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Matt Long <ml@medplum.com>

* Use global system repo for Login reads in revoke and logout

Login is a global/protected resource type, so reading and revoking
logins should use getGlobalSystemRepo() rather than the request
context's project-scoped systemRepo.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Matt Long <ml@medplum.com>

* Deduplicate super admin creation in seed.ts

Replace inline Practitioner and ProjectMembership creation with calls
to the existing createProfile and createProjectMembership utilities,
removing ~25 lines of duplicated code.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Matt Long <ml@medplum.com>

* Deduplicate login membership setting in newproject.ts

Replace inline Login update with a call to the existing
setLoginMembership utility, removing duplicated logic.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Matt Long <ml@medplum.com>

* [autofix.ci] apply automated fixes

---------

Signed-off-by: Matt Long <ml@medplum.com>
Co-authored-by: Claude Opus 4.6 (1M con... (continued)

17912 of 20339 branches covered (88.07%)

Branch coverage included in aggregate %.

23 of 23 new or added lines in 10 files covered. (100.0%)

32545 of 34378 relevant lines covered (94.67%)

14560.48 hits per line