23364608671
82%

Ran 20 Mar 2026 10:13PM UTC

Jobs 1

Files 72

Run time 1min

Badge

Embed ▾

Committed 20 Mar 2026 10:09PM UTC coverage: 82.694%. Remained the same

Build # 23364608671

Build Type

push

github

Committed by

web-flow

Commit Message

fix(modem): set BLE GAP device name to `sonde-modem` (#396)

* fix(modem): set BLE GAP device name to `sonde-modem`

Call `set_device_name` on the `BLEDevice` singleton immediately after
`BLEDevice::take()` in `EspBleDriver::new()` so that connected clients
(e.g. Android) see `sonde-modem` instead of the NimBLE default (`nimble`).

The advertising payload already set the name via
`BLEAdvertisementData::name()`, but the GAP device name — which Android
reads after connecting — was never configured.

Closes #324

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix(modem): address PR review — const device name + error context

- Extract BLE_DEVICE_NAME const to avoid drift between GAP record and
  advertising payload.
- Use unwrap_or_else to include underlying error in panic message.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix(modem): log warning instead of panicking on GAP name failure

Replace \panic!()\ in \set_device_name\ with a \warn!()\ log so a
non-critical cosmetic failure does not crash or boot-loop the modem.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Coverage Stats

16973 of 20525 relevant lines covered (82.69%)

49.07 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	23364608671.1	20 Mar 2026 10:13PM UTC	72	82.69	GitHub Action Run

Alan-Jowett / sonde / 23364608671
82%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 23364608671

Alan-Jowett / sonde / 23364608671 82%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 23364608671

Alan-Jowett / sonde / 23364608671
82%

README BADGES
x