Alan-Jowett / sonde / 23364140194

82%

push

github

fix(pairing-tool): close 5 implementation gaps and Android BLE timeout deviation (#392)

* fix(pairing-tool): close 5 implementation gaps from code compliance audit

- D10-003: Fix Android BLE connection timeout from 30s to 10s (PT-1002)
- D8-003: Add intermediate phase states (Connecting, Provisioning) to
  UI phase tracking for better operator feedback (PT-0701)
- D8-002: Add already-paired detection prompt in \pair_gateway\ command;
  returns an error with the existing gateway ID unless \orce=true\ is
  passed (PT-0601)
- D10-002: Improve error messages with actionable operator guidance
  (e.g. check modem power, verify registration window) (PT-0501)
- D9-3/D9-5: Document plaintext-to-encrypted storage migration and
  Linux Secret Service key provider in the design doc

Closes #387

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: address PR #392 review comments

- Set phase to Error before early returns on existing gateway identity
  (pair_with_gateway, both desktop and Android variants)
- Move Connecting phase assignment after parse_address validation so
  failed parses don't leave the UI stuck in Connecting
  (pair_with_gateway and provision_node, both desktop and Android)
- Fix doc: Secret Service unavailability returns an error, not a
  plaintext fallback

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: cargo fmt

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: address PR #392 review comments

- Remove redundant `Connecting` phase in `provision_node` (desktop + Android)
  that was immediately overwritten by `Provisioning`
- Return structured `already_paired:<gateway_id>` error from `pair_gateway`
  (desktop + Android) so the frontend can parse it and re-invoke with
  `force: true`

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: address PR #392 review comments

- Add PairingProgress callback trait to phase1::pair_with_gateway for... (continued)

130 of 174 new or added lines in 2 files covered. (74.71%)

16973 of 20525 relevant lines covered (82.69%)

49.06 hits per line