Alan-Jowett / sonde / 23361207316

82%

push

github

fix(protocol): implement key_hint_from_psk, fix COMMAND CBOR key ordering, document missing types/modules (#391)

* fix(protocol): implement key_hint_from_psk, fix COMMAND CBOR key ordering, document missing message types and modules

- Add key_hint_from_psk() to protocol crate (design doc §5.5)
- Fix COMMAND CBOR key emission order from {4, 13, 14, 5} to {4, 5, 13, 14}
  for deterministic CBOR compliance (RFC 8949 §4.2)
- Add PEER_REQUEST (0x05) and PEER_ACK (0x84) to protocol.md §4
- Document modem.rs and le_envelope.rs modules in protocol-crate-design.md
- Add tests for key_hint_from_psk and COMMAND CBOR key ordering

Closes #383

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: address PR #391 review comments

- Update modem module docs to match actual API (ModemMessage, encode_modem_frame/decode_modem_frame, FrameDecoder with push/decode)
- Remove redundant assert_ne!(hint, 0) in key_hint test
- Replace flaky uniqueness assertion with exact expected-value checks

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: resolve CI format and lint failures

- Run cargo fmt to fix formatting in messages.rs and validation.rs
- Remove needless borrows (&psk_a, &psk_b) flagged by clippy

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: address PR #391 review comments

Use sha2 crate directly in test_key_hint_from_psk for independent
verification instead of reusing the same SoftwareSha256 provider
that the function under test uses.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: address PR #391 review comments

- Update CBOR key ordering comment in messages.rs to note KEY_PAYLOAD
  is optional for Nop/Reboot commands
- Move non-T-Pxxx tests (key_hint_from_psk, CBOR key ordering) from
  validation.rs to a new tests/unit.rs to preserve traceability

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Alan ... (continued)

7 of 7 new or added lines in 2 files covered. (100.0%)

16532 of 20007 relevant lines covered (82.63%)

49.64 hits per line