supabase / supavisor / 23354780349

82%

Build Type

push

github

Committed by web-flow

Commit Message

fix: improve handling of database connection failures (#884)

Handles 57p03, doing a graceful pool shutdown.

Removes the existing retry state in favor of relying on poolboy
restarting us, and introducing a connection_cooldown state. This ensures
that both connection closed and failures to connect in general are
treated the same way, and avoids some erroneous behaviour[1] after
disconnects.

New state diagram:

<img width="1164" height="982" alt="image"
src="https://github.com/user-attachments/assets/958eaf8f-7047-4a1e-829f-79db8cde5b4f"
/>


[1] Reconnect_on_db_close could silently reconnect losing server-side
only session state. Since supavisor doesn't track the whole state
necessary to recover the connection, the new connection could not
exactly match the previous one, causing errors for the clients.

Run Details

49 of 51 new or added lines in 5 files covered. (96.08%)

7 existing lines in 7 files now uncovered.

2573 of 3123 relevant lines covered (82.39%)

58994.37 hits per line