tarantool / tarantool / 23342567307

88%

Build Type

push

github

Committed by locker

Commit Message

coll: deprecate custom collations

Allowing users to create and modify collations is dangerous because it
may change the order of data stored on disk. We shouldn't have allowed
it in the first place. Another issue with custom collations is the
global collation registry: since it can be modified at any time, we'd
have to synchronize access to it in order to allow using tuples in
application threads (tuple formats and key definitions refer to
collations). Let's deprecate this feature and schedule it for removal
in Tarantool 4.0.

The implementation is simple. At startup we create predefined collations
(same as those created by box.schema.upgrade) and add them to the
collation cache. When a new collation is created, we check if there's
already the same collation in the cache and reuse it if so. If there's
no collation to reuse, we log a deprecation warning.

Closes #12209

NO_DOC=support for custom collations was never documented

Run Details

70558 of 118729 branches covered (59.43%)

26 of 28 new or added lines in 1 file covered. (92.86%)

43 existing lines in 15 files now uncovered.

106090 of 120976 relevant lines covered (87.7%)

1354250.53 hits per line