pataar / browser-detect / 23341586198

100%

main: 100%

push

github

refactor: code quality improvements (#12)

* refactor: code quality improvements

- DeviceDetector: call skipBotDetection() once on init, not every request
- DeviceDetector: remove dead $pieces array and version string from
  parseVersion() (always overwritten by BrowserDetect::buildVersionAndName)
- DeviceDetector: inline $device array, lazy-fetch brand/model only
  when device type is present
- DeviceDetector: tighten parseVersion() return type to array<string, int>
- BrowserDetect: simplify device resolution to only write changed flags
- BrowserDetect: use word-boundary regex for IE match to prevent
  false positives on browser names containing 'ie' as a substring
- BrowserDetect: pass agent string directly to detectIsInApp() instead
  of re-fetching from payload
- BrowserDetect: consolidate in-app token checks into const array + loop
- Result: replace stringly-typed deviceType() magic dispatch with
  explicit property checks

* chore: add issue and pull request templates

- Bug report template with UA string, expected/actual behaviour, version
- Feature request template with description, use case, example UAs
- PR template with checklist enforcing 100% test coverage

31 of 31 new or added lines in 3 files covered. (100.0%)

248 of 248 relevant lines covered (100.0%)

26.67 hits per line