tari-project / tari / 23336911046
62%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 701
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 61.697% (+0.7%) from 60.967%
23336911046

push

github

web-flow 
fix(wallet): save complete burn proof in file (#7726)

Description
---
fix(wallet): save complete burn proof in file

Motivation and Context
---
Use a shared file location for burn proofs, this allows L2 wallets to
pick up burns for claiming

   ## Summary
- Automatically writes a complete burn proof JSON file to a configurable
directory after a burn transaction is confirmed and the merkle proof is
fetched from the base node, removing the need for users to
   manually specify a file path in the TUI
- Introduces `CompleteClaimBurnProof` and `BurnClaimProof` types in
`tari_sidechain` that include all data needed by an L2 wallet daemon
(merkle proof, abridged kernel, encrypted data, value)
- Renames the existing `BurnClaimProof` to `PartialBurnClaimProof` to
clarify it lacks the merkle proof and other fields only available after
confirmation
- Adds a new `TransactionBurnConfirmed` event emitted when the proof
file is written
- Adds `--burn-proof-out` CLI flag and `burn_proofs_dir` config option
(defaults to platform data dir e.g. `~/.local/share/tari/burn_proofs`)
- Removes the manual "burn proof filepath" input field from the console
wallet TUI burn tab

How Has This Been Tested?
---
Manually

What process can a PR reviewer use to test or verify this change?
---

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->

0 of 60 new or added lines in 8 files covered. (0.0%)

28 existing lines in 9 files now uncovered.

70617 of 114458 relevant lines covered (61.7%)

227034.97 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
0.0
 0.0% base_layer/wallet/src/transaction_service/protocols/transaction_validation_protocol.rs
1
0.0
 0.0% base_layer/wallet/src/transaction_service/storage/database.rs
1
40.75
 0.0% base_layer/wallet/src/transaction_service/storage/sqlite_db.rs
5
0.0
 0.0% base_layer/wallet/src/config.rs
10
0.0
 0.0% base_layer/wallet/src/transaction_service/protocols/fetch_claim_burn_merkle_proofs.rs
10
0.0
 0.0% base_layer/wallet/src/transaction_service/service.rs
13
0.0
 0.0% base_layer/wallet/src/transaction_service/config.rs
19
0.0
 0.0% base_layer/wallet/src/transaction_service/handle.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
21.84
 -1.15% base_layer/core/src/chain_storage/error.rs
1
66.57
 -0.29% base_layer/core/src/mempool/sync_protocol/mod.rs
1
93.76
 -0.19% base_layer/core/src/proof_of_work/monero_rx/merkle_tree.rs
1
75.34
 -1.37% base_layer/node_components/src/blocks/chain_block.rs
1
0.0
 0.0% base_layer/wallet/src/config.rs
1
63.09
 -0.21% comms/dht/src/connectivity/mod.rs
2
83.39
 -0.33% comms/core/src/protocol/rpc/client/mod.rs
3
79.11
 -0.7% base_layer/transaction_components/src/validation/aggregate_body/aggregate_body_internal_validator.rs
17
54.32
 5.54% base_layer/core/src/chain_storage/lmdb_db/lmdb_db.rs
Jobs
ID Job ID Ran Files Coverage
1 23336911046.1 701
61.7
 GitHub Action Run
Source Files on build 23336911046