pataar / browser-detect / 23337181878

100%

main: 100%

push

github

fix: bugs, code quality, and efficiency improvements (#5)

* fix: bugs, code quality, and efficiency improvements

Bug fixes:
- Fix isTable typo (should be isTablet) in Prerender bot checks
- Fix bots incorrectly marked as isDesktop=true
- Use consistent case-insensitive stripos for Prerender detection
- Merge overlapping Prerender desktop/mobile bot checks
- Fix wrong comment labeling WeChat check as Twitter
- Fix copy-paste PHPDoc for isFirefox, isOpera, isSafari in ResultInterface

Code quality:
- Extract buildVersionAndName() helper to DRY up browser/platform version assembly
- Use local variables for repeated getValue/getAgent calls in BrowserDetect stage
- Collapse three identical Blade::if registrations into a loop
- Simplify Payload::getValue to use null coalescing operator

Efficiency:
- Replace crc32 with xxh128 for cache keys (collision-safe)
- Reuse CrawlerDetect library instance across invocations
- Reuse MobileDetect library instance across invocations
- Call skipBotDetection(true) once at DeviceDetector construction

* revert: remove bot-is-not-desktop change to avoid breaking change

52 of 52 new or added lines in 7 files covered. (100.0%)

285 of 285 relevant lines covered (100.0%)

27.42 hits per line