stacklok / toolhive / 23334526557

64%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(vmcp): pull optimizer and composite tool decoration into session factory (#4231)

Move optimizer and composite tool construction from server-level post-session
decoration into the MultiSessionFactory via a new DecoratingFactory wrapper.
Sessions are now fully formed at creation time — the server unconditionally
calls the factory and always gets a decorated MultiSession.

- Add session.Decorator type and NewDecoratingFactory to apply decorators at
  session construction time
- Add adaptToolsForFactory helper for optimizer tool indexing without
  session-manager-specific terminate callbacks
- Move composite tool converter functions (FilterWorkflowDefsForSession,
  ConvertWorkflowDefsToTools, ValidateNoToolConflicts) out of server/ into
  the compositetools package where they belong
- Remove DecorateSession and GetMultiSession from SessionManager interface
  and implementation — no longer needed
- Delete adapter/optimizer_adapter.go (re-export of constants already in
  optimizerdec); delete its trivial test
- Apply early-return guard clause in compositetools.CallTool to reduce nesting

Closes: #3872

Co-authored-by: taskbot <taskbot@users.noreply.github.com>

Run Details

357 of 470 new or added lines in 6 files covered. (75.96%)

6 existing lines in 3 files now uncovered.

50046 of 77261 relevant lines covered (64.78%)

72.99 hits per line