Azure / karpenter-provider-azure / 23327377885

94%

main: 95%

Pull #1549

github

feat: add Machine API dry-run validation to ValidationReconciler

Add a MachineAPIDryRunReconciler that validates AKSNodeClass configuration
against AKS RP's real Machine API validator by sending a dry-run PUT
request (?dryRun=true). This catches validation drift between CRD-level
rules and RP-level rules without maintaining parallel validation logic.

The implementation adds:
- dryRunPolicy: Azure SDK per-call policy that appends ?dryRun=true
  to PUT requests (same pattern as spotSystemNodePolicy)
- AKSMachinesDryRunClient: separate Machines client with the dry-run
  policy, exposed via AZClient.AKSMachinesDryRunClient()
- MachineAPIDryRunReconciler: builds a template Machine from
  AKSNodeClass fields (OSDiskSizeGB, kubelet config, FIPS, subnet)
  and sends it through the dry-run client. Sets
  ConditionTypeValidationSucceeded=False on 4xx validation errors.
  Gracefully degrades when the RP endpoint isn't deployed yet.

Depends on: aks-rp PR #15118823 (PutMachine dry-run endpoint)
Related: Azure/karpenter-poc#1708

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

0 of 114 new or added lines in 3 files covered. (0.0%)

58827 of 62836 relevant lines covered (93.62%)

0.95 hits per line