kubeovn / kube-ovn / 23326660376
23%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 205
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 23.375%. Remained the same
23326660376

push

github

web-flow 
fix(helm): match control-plane nodes by label presence when value is empty (#6479)

* fix(helm): match control-plane nodes by label presence when value is empty

The kubeovn.nodeIPs helper and deployment nodeSelectors used strict
value matching to find master nodes by MASTER_NODES_LABEL. When the
label is configured without a value (e.g.
"node-role.kubernetes.io/control-plane"), the match requires an empty
string, which fails on k3s clusters where the label value is "true".

Changes in kube-ovn chart:
- _helpers.tpl: use hasKey + conditional value check instead of strict
  eq; handle trailing "=" and values containing "=" correctly via
  rest+join; add kubeovn.masterNodeAffinity helper to avoid duplication
- Deployment templates (central, monitor, ic-controller): replace
  nodeSelector label matching with nodeAffinity via the new helper,
  merged into the existing affinity block alongside podAntiAffinity
- Add helm-unittest tests covering all three deployments, edge cases
  (trailing =, value with =)

Changes in kube-ovn-v2 chart:
- _helpers.tpl: same hasKey fix with nil-safe check (toString for YAML
  null handling); add kubeovn.masterNodeRequired helper that creates
  separate nodeSelectorTerms per label for OR semantics (matching the
  OR logic in kubeovn.nodeIPs and the values.yaml documentation)
- Deployment templates: use kubeovn.masterNodeRequired via the existing
  kube-ovn.affinities.nodeAffinity helper
- Add helm-unittest tests including multi-label OR semantics and
  ic-controller coverage

This makes the chart compatible with all Kubernetes distributions
regardless of whether they set the control-plane label to an empty
string (kubeadm, Talos) or "true" (k3s).

Assisted-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>

* fix(helm): coerce label values to string for type-safe comparison

YAML parses unquoted true as boolean, not string. Use toString to
ensure label value comparisons and matchExpressions values ... (continued)

12899 of 55182 relevant lines covered (23.38%)

0.27 hits per line

Jobs
ID Job ID Ran Files Coverage
1 23326660376.1 205
23.38
 GitHub Action Run
Source Files on build 23326660376