libcgroup / libcgroup / 23312229513

56%

Build Type

push

github

Committed by drakenclimber

Commit Message

tools/cgxget: free temporary conversions on failure paths

AddressSanitizer reported an 8-byte leak when convert_cgroups() aborted:

    Direct leak of 8 byte(s) in 1 object(s) allocated from:
        #0 0x... in __interceptor_malloc
        #1 convert_cgroups (<libcgroup-source>/src/tools/cgxget.c:822)
        #2 main (<libcgroup-source>/src/tools/cgxget.c:893)

The helper allocates a scratch cgroup list, but on failures or
ECGNOVERSIONCONVERT it returned without releasing the partially built
array. Worse, when the scratch malloc failed we still treated the
conversion as “success” and left the old list pointing nowhere.

Return an error if the allocation fails, zero-initialise the scratch
list so we can free partially populated slots safely, free every
temporary cgroup before returning on error, and only after a successful
conversion free the original list (including the pointer array) before
swapping in the new one. With these guards in place the ASan leak report
is gone.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

Run Details

6 of 12 new or added lines in 1 file covered. (50.0%)

276 existing lines in 2 files now uncovered.

5631 of 10036 relevant lines covered (56.11%)

611.72 hits per line