ossuminc / riddl / 23304100341

66%

main: 66%

Build Type

push

Committed by reid-spencer

Commit Message

Fix BAST deserialization bugs for LetStatement and MatchStatement

Two reader-side fixes that caused byte misalignment during BAST
deserialization, manifesting as failures on large models like
reactive-bbq (4428 nodes):

1. LetStatement: Added missing readU8() to consume the
   NODE_PATH_IDENTIFIER tag before readPathIdentifierNode() when
   reading the optional TypeRef added in 1.16.0. The writer uses
   writePathIdentifier() which includes the tag byte, but the
   reader was not consuming it — causing 1-byte drift.

2. MatchStatement: Changed reader to match the writer's byte
   layout where all case headers (loc + pattern + count) are
   written first, followed by all case items sequentially, then
   default items. The reader was incorrectly interleaving each
   case's header with its items.

Also removes pre-populated keywords from StringTable (90 entries
that were always serialized regardless of usage, ~5-85% size
reduction) and adds regression tests for epics and typed let
statements. Removes the reactive-bbq pending marker — all 187
riddl-models now pass round-trip testing.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Run Details

18 of 18 new or added lines in 1 file covered. (100.0%)

12 existing lines in 9 files now uncovered.

6802 of 10284 relevant lines covered (66.14%)

0.66 hits per line