babelfish-for-postgresql / babelfish_extensions / 23299065744
77%
BABEL_5_X_DEV: 77%

LAST BUILD BRANCH: BABEL_6329_6x
DEFAULT BRANCH: BABEL_5_X_DEV
Ran
Jobs 1
Files 121
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 77.05%. Remained the same
23299065744

push

github

web-flow 
Implement STGeometryType for geometry and geography types (#4669)

Implemented the `STGeometryType()` method for both `sys.GEOMETRY` and `sys.GEOGRAPHY` types, extending the existing geospatial functionality in Babelfish. This function returns the geometry type name (Point, LineString, Polygon, etc.) with full TSQL compatibility.

#### Changes Made

**Function Implementations:**
- `STGeometryType` for `sys.GEOMETRY` - Returns geometry type name with proper validation
- `STGeometryType` for `sys.GEOGRAPHY` - Returns geography type name with same behavior
- Utilizes PostGIS functions with necessary adjustments for TSQL compatibility
- Strips 'ST_' prefix from PostGIS type names to match TSQL Server format

**Key Features:**
- **Input Validation:** Validates geometry/geography instances using `STIsValid()` before processing
- **Error Handling:** Throws appropriate exceptions for invalid instances
- **SQL Server Compatibility:** Returns `sys.NVARCHAR` type and matches TSQL naming conventions
- **NULL Handling:** Proper handling of NULL inputs with STRICT function attribute
- **Thread Safety:** Implemented with PARALLEL SAFE attribute

---

#### Examples

**For STGeometryType (Geometry):**

    DECLARE @geom geometry;
    SET @geom = geometry::STGeomFromText('POINT(1 2)', 4326);
    SELECT @geom.STGeometryType();

**Output:** `Point`

**For STGeometryType (Geography):**

    DECLARE @geog geography;
    SET @geog = geography::STGeomFromText('LINESTRING(-122.36 47.65, -122.34 47.66)', 4326);
    SELECT @geog.STGeometryType();

**Output:** `LineString`

**Table Operations:**

    SELECT ID, GeomColumn.STGeometryType() AS GeometryType 
    FROM TestTable 
    WHERE GeomColumn.STGeometryType() = 'Point';

---

#### Files Modified

- `geometry.sql` - Added STGeometryType for geometry type
- `geography.sql` - Added STGeometryType for geography type
- `spatial_types--6.0.0--6.1.0.sql` - Upgrade script
- Test files with comprehensive coverage

Task: BABEL-6310
Sig... (continued)

52917 of 68679 relevant lines covered (77.05%)

643410.63 hits per line

Jobs
ID Job ID Ran Files Coverage
1 23299065744.1 121
77.05
 GitHub Action Run
Source Files on build 23299065744