GEWIS / sudosos-backend / 23269647348

89%

push

github

feat: unified transfer aggregate endpoint (#804)

* feat: add unified transfer aggregate endpoint

Adds GET /transfers/aggregate that returns the DB-side SUM and COUNT of
transfers matching optional filters (fromDate, tillDate, fromId, toId,
category).

- Add TransferCategory enum for the seven decorator relations
  (deposit, payoutRequest, invoice, fine, waivedFines, writeOff,
  inactiveAdministrativeCost)
- Add TransferAggregateFilterParameters and parseGetTransferAggregateFilters
- Add TransferService.getTransferAggregate() using QueryBuilder SUM
- Add TransferAggregateResponse typedef
- Fix existing parseGetTransferFilters bug: fromId/toId were both reading
  from req.query.id instead of their own query params
- Tests cover: model validation, full aggregate, fromId/toId filtering,
  category filtering, empty result, date range, invalid category, auth

Closes #800

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: apply PR review feedback

- Strengthen deposit category test: compute exact expected count/total
  via queryBuilder innerJoin, assert equality instead of lower bounds
- Add GET /transfers?fromId= and ?toId= filter tests to verify the
  parseGetTransferFilters bug fix is covered by tests

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: remove unused depositTransfer variable

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

1793 of 2199 branches covered (81.54%)

Branch coverage included in aggregate %.

40 of 42 new or added lines in 2 files covered. (95.24%)

9245 of 10187 relevant lines covered (90.75%)

993.31 hits per line