Qiskit / qiskit / 23265974047

87%

Build Type

push

github

Committed by web-flow

Commit Message

Use struct for `NodeDurations` in both `ALAP` and `ASAP` Scheduling Passes (#15276)

* Initial: Reorganize schedule analysis passes
- Add initial ``NodeDurations`` struct.

* Fix: Use NodeDurations struct on passes
This commit is incomplete and most features will stop working.

* Add: Use `NodeDurations` in python.
- Add magic methods to `PyNodeDurations`.

* Fix: Use indices to get nodes from Dynamical Decoupling passes
- Add `items` method.

* Lint: Formatting

* Fix: Keep original dag nodes and give path to getting them from scratch.
- Add an extra field to `PyNodeDurations` to keep mapping between indices and original dag nodes.
- Add methods to update `NodeDurations` using mappings with a subset of the current nodes or new mappings as long as the user has the original dag.
- Reverted some changes inside of Context Aware DD.

* Format: Elide lifetimes.

* Apply suggestions from code review

Co-authored-by: Alexander Ivrii <alexi@il.ibm.com>

* Fix: Add missing magic methods.

* Fix: Pre-computing error in `__getitem__`
- An oversight allowed an error variant to precompute itself even if the result was `Ok` via `ok_or`. Replaced it with `ok_or_else`.
- Fix formatting issue.

* Add: `__iter__`, `keys` and `values` to `NodeDurations`.

---------

Co-authored-by: Alexander Ivrii <alexi@il.ibm.com>

Run Details

201 of 288 new or added lines in 9 files covered. (69.79%)

8 existing lines in 3 files now uncovered.

101837 of 116724 relevant lines covered (87.25%)

1156314.95 hits per line