node-opcua / node-opcua / 23259784310

93%

Build Type

push

github

Committed by erossignon

Commit Message

fix: setValueFromSource corrupts terminal-type fields in bound extension objects

The _update_extension_object function used
`instanceof Object` to decide whether to recurse
into a field. Since all non-primitive types satisfy
this check (Date, Buffer, NodeId, QualifiedName,
LocalizedText, DiagnosticInfo, arrays), the function
recursed into them instead of assigning directly
through the proxy.

This caused two bugs:
- Date values silently revert to 1601-01-01 because
  Object.keys(date) returns [], so nothing is set.
- All terminal object types bypass the proxy set
  trap, so child variable value_changed events are
  never emitted and OPC UA subscriptions silently
  miss changes.

The fix replaces `instanceof Object` with two
whitelist functions:
- _shouldRecurseIntoExisting: uses isProxy() to
  identify sub-structures installed by
  bindExtensionObject
- _shouldRecurseIntoNew: uses plain-object check
  plus constructor name exclusions for QualifiedName,
  LocalizedText, DiagnosticInfo (which have schema
  but are terminal types)

Added 13 unit tests (TV-1..9 value tests +
NB-1..4 notification tests) with XML fixture
covering all terminal types.

Also applied biome lint fixes (noExplicitAny) across
test_bindExtensionObject.ts,
test_extension_object_with_dates.ts, and
test_bug_setValueFromSource_terminal_values.ts.

Run Details

18315 of 21703 branches covered (84.39%)

43 of 46 new or added lines in 1 file covered. (93.48%)

3 existing lines in 1 file now uncovered.

161501 of 174167 relevant lines covered (92.73%)

463039.95 hits per line