romshark / datapages / 23246242048

45%

Build Type

push

github

Committed by romshark

Commit Message

feat!: Purge signals param from event handlers

BREAKING: OnXXX event handlers no longer accept a `signals` parameter.
These held signal values from the time the SSE stream was established
and could go stale but the intuitive perception of a dev would be
"those are the signals values at the time the event was received".
It's a foot gun and not worth having. If a handler needs signal values,
add them as fields on the event type and pass them from the action
handler that dispatches the event.

Run Details

13 of 18 new or added lines in 4 files covered. (72.22%)

10 existing lines in 4 files now uncovered.

8581 of 19290 relevant lines covered (44.48%)

21.29 hits per line