dtcenter / METplus / 23213683721

92%

main_v6.2: 92%

push

github

Bugfix dtcenter/met#3362 diff nc var att - round 2 (#3256)

* Per MET #3362, add logic to diff_util.py to check variable attributes for diffs.

* Enhance logic to report differences in NetCDF attributes -- which attributes are found in one and not the other and which attributes have different values. Also continue to check for differences in data even if attributes differ

* refactor to reduce cognitive complexity per SQ

* added unit tests to test new diff util logic that compares NetCDF attributes

* Improve NetCDF diff logic to properly handle attributes that are numpy arrays, NaN values. Only log NC variable info if there is a failure or if METPLUS_DIFF_VERBOSE is set. Added more unit tests to demonstrate tests that incorrectly failed in the METplus use case runs

* allow override of dummy netcdf fill value

* fix logic to handle NetCDF attribute diffs when nans are present

* update versions of actions to resolve Node.js 20 action deprecation warnings

* update version of action to scan docker images to resolve Node.js 20 deprecation

---------

Co-authored-by: John Halley Gotway <johnhg@ucar.edu>

34 of 37 new or added lines in 1 file covered. (91.89%)

9639 of 10471 relevant lines covered (92.05%)

1.84 hits per line