MITLibraries / alma-sapinvoices / 23209794529

100%

main: 100%

Pull #274

github

refactor error handling for warnings

-  adds new data structure to sap invoice data to hold all errors for each invoice for which we want to generate warnings

- Error classes handle constructing their own messages, so generating the warning from the errors is greatly simplified

- Vendor errors are consolidated
using class methods to construct
the different error messages for each type of vendor error

- Check for multibyte uses recursion to step through the sap invoice data
rather than relying on the flatdict library

- removes has_errors(). It is no longer needed. Now we just check for the "errors" key in the sap invoice data

- added generic invoice, vendor, and fund fixtures to make invoicing parsing tests more transparent

125 of 125 new or added lines in 1 file covered. (100.0%)

685 of 685 relevant lines covered (100.0%)

1.0 hits per line